GH-43244: [C++][Parquet] Supports write BinaryView/StringView to Parquet file #45413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
|
Could you please review this when you have a moment? @mapleFU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
BinaryView/StringVieware two new types added in Arrow, this PR aims to add support for writing these types into Parquet files.What changes are included in this PR?
Supports write
BinaryView/StringViewto Parquet fileAre these changes tested?
I have reimplemented all relevant tests originally designed for
BinaryandStringtypes incpp/src/parquet/arrow/arrow_schema_test.ccandcpp/src/parquet/encoding_test.cc, adapting them forBinaryViewandStringView, not sure if there is anything more to do.Are there any user-facing changes?
I suppose no?